Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a sticky menu component #2736

Open
padms opened this issue Dec 24, 2024 · 6 comments · Fixed by #2740
Open

Create a sticky menu component #2736

padms opened this issue Dec 24, 2024 · 6 comments · Fixed by #2740
Assignees
Labels

Comments

@padms
Copy link
Contributor

padms commented Dec 24, 2024

We would like to create a sticky menu that follows a user as the scroll down a page. This would be used for the Annual report landing page in the first iteration to allow the main AP PDF to be accessed by user.

The component should be visible as user scrolls down the page
The component should allow editor to add a title
The component should have an option to add an anchor link to jump down to a given point on the page
The component should allow editor to add a download
Options for colour background: White + light green as per sketch.
Use new design for Download CTA inc new Icon for PDF
Should the component not feature on mobile?

Screenshot 2024-12-19 at 14.40.00.png

Inspiration:
https://www.apple.com/environment/

Challenges:
How does it interact with the main menu? Apple example works well when user scrolls back up.
Should we replicate the shadow of the main menu on the sticky menu?

@padms padms self-assigned this Dec 24, 2024
padms added a commit that referenced this issue Jan 20, 2025
@padms
Copy link
Contributor Author

padms commented Jan 21, 2025

@nicholas-haggerty This is ready to be reviewed.

@NickHaggerty1
Copy link

@padms Great thanks for this. Some comments:

  • In the studio we should add the sticky menu content under a drop down (like SEO)
  • The title font for the menu seems quite bold/heavy. Think we could take the weight down (not size)
  • The background colour does not seem to change (Always light green despite selecting white or having no select)
  • Think we need a little more space between the link/download titles and the arrow (probably double what it is now)
  • Lets remove the component from mobile view (seems also to have a couple of issues on mobile)

padms added a commit that referenced this issue Jan 22, 2025
padms added a commit that referenced this issue Jan 22, 2025
padms added a commit that referenced this issue Jan 22, 2025
padms added a commit that referenced this issue Jan 22, 2025
@padms
Copy link
Contributor Author

padms commented Jan 22, 2025

@NickHaggerty1 Ready for another round of review.

@NickHaggerty1
Copy link

@padms Thanks.

  • Can we move the "title" to be more inline with the logo? Screen grab attached.
  • Potentially could move the link/downloads to align with the menu but not sure if there is a space reason its more to the right side of the menu?
  • When I remove the anchor link. The title goes away but the arrow remains?
Image Image

padms added a commit that referenced this issue Jan 22, 2025
padms added a commit that referenced this issue Jan 23, 2025
@padms
Copy link
Contributor Author

padms commented Jan 23, 2025

Back to review with the fixes :) @NickHaggerty1

@NickHaggerty1
Copy link

@padms Thanks so much. Think we are approved!

padms added a commit that referenced this issue Jan 23, 2025
* ✨ Sticky Menu Component

* 💄 Remove additional classes #2736

* Miised commit

* ♻️ Add validations and exclude colors #2736

* ♻️ Changes after review #2736

* 💄 Fix bg in tw #2736

* ♻️ Fix after comments #2736

* 🐛 Handle error #2736

* 🐛 After 2 nd review #2736

* 💄 Use tailwind #2736
@padms padms linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants