Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitelisting paths to load playlist files from #577

Closed
mkataja opened this issue Dec 20, 2024 · 8 comments
Closed

Allow whitelisting paths to load playlist files from #577

mkataja opened this issue Dec 20, 2024 · 8 comments
Milestone

Comments

@mkataja
Copy link

mkataja commented Dec 20, 2024

Nice work with the m3u playlists loading!

My issue now is that LMS loads too many playlist files, since a lot my album directories contain playlists for those albums. I would not like to delete those playlists, but I would also not like to see them in LMS.

My proposed solution is to add a config option containing a list of paths eligible to load playlists from. Any playlist file not matching a path in this list would simply be ignored. Leaving the list empty would keep current behavior of loading all playlists.

@epoupon
Copy link
Owner

epoupon commented Dec 21, 2024

Hello! Thanks for your feedback.
To better understand, do you actually use all these playlists? What are they for?

@AverageHoarder
Copy link

While I don't know what people use them for (maybe open an entire album in vlc with a double click, who knows?), I've encountered hundreds of albums that contained an .m3u or .m3u8 file with paths to the tracks of the album.
Luckily I opted to always remove these as I don't use them (and rename the tracks so they'd be broken anyhow) but if you keep them you can easily end up with hundreds of playlists, each named like the album it belongs to.

Limiting the possible paths to import playlists from would be useful for users who opted to keep these files.

@epoupon
Copy link
Owner

epoupon commented Dec 26, 2024

Ok I see. Maybe an option to skip playlists that are just indexing a whole album would be easier to use?

@mkataja
Copy link
Author

mkataja commented Jan 1, 2025

Sorry about not getting back to this despite your prompt response! Christmas holidays and stuff.

And yes, it's exactly as @AverageHoarder said.

Ok I see. Maybe an option to skip playlists that are just indexing a whole album would be easier to use?

Hmm, not entirely sure how this would work? I've got some playlists indexing entire directories (but not albums), and I would like to keep those playlists.

@epoupon
Copy link
Owner

epoupon commented Jan 2, 2025

I meant this: if the tracks of the playlist all belong to the same album (not the same directory), then it is omitted. Could be even omitted only if it contains exactly all the tracks of the album

@mkataja
Copy link
Author

mkataja commented Jan 2, 2025

That sounds good to me!

@AverageHoarder
Copy link

AverageHoarder commented Jan 2, 2025

Depending on how you plan to implement this check I see a possible problem.
Some people leave the .m3u(8) file in the folder (same goes for .cue files), but retag and then rename the tracks and album folder, essentially breaking the links in the m3u(8) file. So the album part in the .m3u(8) might not match the actual folder name or the content of the album tag.

@epoupon
Copy link
Owner

epoupon commented Jan 2, 2025

Orphan tracks inside playlists are already ignored. Maybe we also need to ignore playlists that are empty.

@epoupon epoupon added this to the v3.63.0 milestone Jan 2, 2025
epoupon added a commit that referenced this issue Jan 15, 2025
@epoupon epoupon closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants