Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos-qogir-icons is outdated #347

Closed
MartinX3 opened this issue Dec 26, 2024 · 6 comments
Closed

eos-qogir-icons is outdated #347

MartinX3 opened this issue Dec 26, 2024 · 6 comments

Comments

@MartinX3
Copy link

See https://github.com/endeavouros-team/PKGBUILDS/tree/master/eos-qogir-icons

New version is
https://github.com/vinceliuice/Qogir-icon-theme/releases/tag/2023-06-05

Maybe that's the reason for
vinceliuice/Qogir-icon-theme#128

Since I use EOS there is no difference switching between Qogir and Qogir-dark.

image

image

@manuel-192
Copy link
Collaborator

Thanks! Updated eos-qogir-icons to version 6-1 which now uses upstream version 2023-06-05.

@MartinX3
Copy link
Author

@manuel-192 Thank you!
Sadly there is still no difference between the light and dark variant in the task bar.
Is it only compatible with a dark task bar?

@killajoe
Copy link
Member

killajoe commented Dec 29, 2024

issue seems that we do not have Qogir-Light in the build ?
2024-12-30_00-35
https://github.com/vinceliuice/Qogir-icon-theme/blob/9e2fec63827d2159e204b768e926f0cb707dfb80/install.sh#L19
COLOR_VARIANTS=('' '-Light' '-Dark')
this is committed after last release and only available if you use git directly instead of release version:
vinceliuice/Qogir-icon-theme@98d25fd

@killajoe
Copy link
Member

Is it only compatible with a dark task bar?

Current state (release) uses symlinking to the same icons for the dark and non-dark variants.
Next release will include the light version that will add black symbolic icons for light theming.
You can try using the git version from AUR:

yay -Rdd eos-qogir-icons
yay -S qogir-icon-theme-git

But be careful with -Rdd .. it ignores dependencies.. and eos-welcome is depending on eos-qogir-icons

@MartinX3
Copy link
Author

MartinX3 commented Dec 30, 2024

Setting the theme to Arc-Lighter, the panel background style to use system style and deactivating the dark mode of the panel together with the Qogir-Light symbols it looks much more readable.

The Qogir symbols are a mix of Dark and Light it seems.

But some of the symbols which are now darker and visible have a weak contrast.
Is this the case because the theme is Arc-Lighter and the Symbols are Qogir-Light and Arc and Qogir are simply not fully compatible?

Arc-Lighter & Qogir-Light
image

Or is probably the Arc-Light theme also missing?
image

And are Qogir-Lighter and Qogir-Darker also missing or are the *er variants just an Arc thing?

Edit:
I see that the Arc theme author simply disappeared and not created a new release tag for the newer commits
jnsh/arc-theme#223
jnsh/arc-theme@2022121...master

So I also better use the *git package of it.
(But this is also a hassle because if an inkscape issue requiring a build parameter as a workaround)

Edit0:
I think I switch away from the EOS default of Arc and Qogir to Orchis.
https://www.xfce-look.org/p/1357889
https://github.com/vinceliuice/Orchis-theme
And use its optional package dependencies tela-circle-icon-theme and vimix-cursors.

It works perfectly in Arch Linux / EndeavourOS with XFCE4 4.20 and the packages are in the official repo.
Maybe the EOS-Team want to migrate the default XFCE experience to it.

@killajoe
Copy link
Member

GTK theme and icons are not mixed or related directly.. icon sets do not really interfere with the GTK-theme.
But indeed you can use what ever fits your needs. We do only provide a basic setup.
arc and qogir are easy to handle and providing full icon set including cursor with it.

Package size is also a thing.
And we do use qogir icons with the EndeavourOS apps too.

May one day we will change if it is needed. For now we will see the fix with the next release of qogir icons. Or we could switch to use git commit as source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants