Something broke in refactoring of url instantiation (#3364) #3467
Unanswered
fredriklj
asked this question in
Potential Issue
Replies: 1 comment
-
Ok, looking at it further I see there are active discussions already ongoing around this: Guidance would be much appreciated if this is really the intended behaviour of this change, and if we should merge the parameters ourselves instead of relying on httpx to do the job? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
After some users upgraded to httpx version >= 0.28.0 they could no longer authenticate through the oauth2 flow. The issue is described here:
CJNE/pyporscheconnectapi#66
After going through the diff between 0.27.2 and 0.28.0 I isolated the problem to be the #3364 PR. If I revert the following lines of code, it all starts working again:
I have not had the opportunity to verify what exactly the effect of the change is on the wire, but I have verified that this change is the cause of the problems, and that reverting it resolves the matter.
Beta Was this translation helpful? Give feedback.
All reactions