GET parameters are no longer merged in 0.28.0

[yan12125]

#3364 changes how GET parameters are handled. For this example script:

import json
import httpx

print(json.dumps(httpx.get("https://httpbin.org/get?foo=bar", params={}).json()))

Results before the PR:

$ python t.py | jq .args
{
  "foo": "bar"
}

And after the PR:

$ python t.py | jq .args
{}

Is that an intentional change? If so, maybe documenting it in changelogs is better.

[tomchristie]

Is that an intentional change? If so, maybe documenting it in changelogs is better.

Yep, I think you've got the right take there. My recollection is that I noticed that the simpler refactoring would also fix a bug along the way, tho then forgot to point that out by the time I came to issue the refactoring. Unfortunately we didn't happen to have a test case covering this.

#3433 (comment)

PRs updating the CHANGELOG there would be welcome. (Possibly also including related tests)

[yan12125]

PRs updating the CHANGELOG there would be welcome. (Possibly also including related tests)

Someone beats me on that :)
#3440

This is probably the most impacting change in 0.28.0. It would be great if changelogs and tests are properly updated before the release.