Local media retention doesn't delete from DB

[erikjohnston]

For media_retention.local_media_lifetime we call:

synapse/synapse/media/media_repository.py

Line 1254 in 696cc9e

await self.store.delete_remote_media(self.server_name, media_id)

which is wrong

[dklimpel]

Local media IDs will deleted:

synapse/synapse/media/media_repository.py

Line 1257 in 696cc9e

await self.store.delete_url_cache_media((media_id,))

synapse/synapse/storage/databases/main/media_repository.py

Lines 907 to 912 in 696cc9e

	async def delete_url_cache_media(self, media_ids: Collection[str]) -> None:
	if len(media_ids) == 0:
	return
	def _delete_url_cache_media_txn(txn: LoggingTransaction) -> None:
	sql = "DELETE FROM local_media_repository WHERE media_id = ?"

But it's really not ideal.

[erikjohnston]

Oooh, good spot!