Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply + /me emote messes up the message body #3919

Open
HarHarLinks opened this issue Aug 30, 2021 · 12 comments
Open

Reply + /me emote messes up the message body #3919

HarHarLinks opened this issue Aug 30, 2021 · 12 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

reply with /me emote(?)

What did you expect?

image

What happened?

Screenshot_20210830-121553590

Your phone model

Moto G5S+

Operating system version

Android 10

Application version and app store

schildi beta f-droid 1.2.0.sc40-test21

Have you submitted a rageshake?

No

@HarHarLinks HarHarLinks added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 30, 2021
@HarHarLinks
Copy link
Contributor Author

#174 #971 #3874 etc etc all the issues with reply fallback

@penn5
Copy link

penn5 commented Aug 30, 2021

I sent the message using FluffyChat where emotes are permitted on replies. Sending a fallback doesn't make sense for that, since it would render wrong, so this isn't an EA issue IMO (except that it should use a proper reply handling rather than the fallback, obviously)

@deepbluev7
Copy link
Contributor

Fallback for emotes is required by the spec: https://matrix.org/docs/spec/client_server/r0.6.1#fallback-for-m-emote

@HarHarLinks
Copy link
Contributor Author

is there a "remove/optional reply fallback" issue/MSC yet?

@MTRNord
Copy link

MTRNord commented Aug 30, 2021

is there a "remove/optional reply fallback" issue/MSC yet?

Rich replies Do that. But Element android does not implement Rich replies at All.

@deepbluev7
Copy link
Contributor

@HarHarLinks MSC to remove it is blocked by Element Android not implementing reply rendering: matrix-org/matrix-spec-proposals#2781

@HarHarLinks
Copy link
Contributor Author

if that is actually the case, then ea should make it a priority. this is not only a reason for many many bugs in ea, but judging from the client/missing rich reply implementation list in that MSC, actually a blocker for most 3rd party clients (i.e. the ecosystem), too.

@deepbluev7
Copy link
Contributor

@HarHarLinks I should update that list. A lot of those clients are unmaintained by now or have implemented reply rendering.

@penn5
Copy link

penn5 commented Aug 30, 2021

Fallback for emotes is required by the spec: https://matrix.org/docs/spec/client_server/r0.6.1#fallback-for-m-emote

I meant that when sending an emote, it doesn't make sense to include a reply fallback since it won't render correctly on spec-compliant clients that lack rich replies.

@HarHarLinks
Copy link
Contributor Author

it seems to me that the fallback is included in a wrong way with that emote and could be fixed to comply with current spec by fluffy?

@penn5
Copy link

penn5 commented Aug 30, 2021

it seems to me that the fallback is included in a wrong way with that emote and could be fixed to comply with current spec by fluffy?

I don't think there is a right way

@deepbluev7
Copy link
Contributor

"body": "> <@krille:janian.de> > <@joydeep_taiga:matrix.org> > <@krille:janian.de> sent an image.\n> > \n> > That's cool. Does it send the encryption keys in the QR?\n> \n> No,but this would be a very cool feature\n\nisn't writing a spec proposal",
        "format": "org.matrix.custom.html",
        "formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!xYvNcQPhnkrdUmYczI:matrix.org/$NTcHK2dLL8uTZF21urFZ5VppsiDjw0jLw5drnO62lAs\">In reply to</a> <a href=\"https://matrix.to/#/@krille:janian.de\">@krille:janian.de</a><br>No,but this would be a very cool feature</blockquote></mx-reply>isn&#39;t writing a spec proposal",

It seems like fluffy didn't send the * in the fallback, but that means the * and bad layout is pretty much only Element Androids fault?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

4 participants