Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(palma): add css support and cdn compatibility #2

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

dcoa
Copy link
Collaborator

@dcoa dcoa commented Dec 1, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (ednx-release/palma.master@17e18e9). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             ednx-release/palma.master       #2   +/-   ##
============================================================
  Coverage                             ?   83.38%           
============================================================
  Files                                ?      101           
  Lines                                ?     2101           
  Branches                             ?      586           
============================================================
  Hits                                 ?     1752           
  Misses                               ?      336           
  Partials                             ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bra-i-am bra-i-am self-requested a review December 12, 2023 16:03
Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

Without the MFE_CONFIG_OVERRIDES

image

With the MFE_CONFIG_OVERRIDES

image

@dcoa dcoa merged commit 219b1aa into ednx-release/palma.master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants