Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logo's to point to theming instead of a static indigo theme #8

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

misilot
Copy link

@misilot misilot commented Feb 19, 2024

Also updated the link to the docs.

@hinakhadim
Copy link

Hi @misilot,

Can you please make the Link commit message and tests pass? Currently these two actions are not able to pass. For commit message, please follow the guidelines.

@hinakhadim hinakhadim self-requested a review March 1, 2024 04:18
@hinakhadim
Copy link

Hey @misilot , any update?

@misilot misilot force-pushed the patch-1 branch 4 times, most recently from 30ed8c8 to 66adc30 Compare April 2, 2024 14:25
@misilot
Copy link
Author

misilot commented Apr 2, 2024

Hi @hinakhadim I fixed the commit message. I don't think the tests were related to my PR, but it looks like they need to be approved to run.

@misilot
Copy link
Author

misilot commented Apr 4, 2024

Hello @hinakhadim is this test failure related to my PR? I didn't touch any textual strings in my change.

@hinakhadim
Copy link

Hello @hinakhadim is this test failure related to my PR? I didn't touch any textual strings in my change.

Yes. Actually the test cases are failing because the current code is tested again already build snapshot which has previous url. Run npm run snapshot and create commit and push. It will make the tests pass.

@misilot
Copy link
Author

misilot commented Apr 4, 2024

Thanks!

I had to run npm install as well.

Hopefully this fixes it?

@hinakhadim
Copy link

Great! all fixed now.

@hinakhadim hinakhadim merged commit 2c5d366 into edly-io:quince/indigo Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants