Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping overloaded build method to receive custom engine #31

Open
jroper opened this issue Jun 15, 2018 · 2 comments
Open

Consider dropping overloaded build method to receive custom engine #31

jroper opened this issue Jun 15, 2018 · 2 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@jroper
Copy link
Member

jroper commented Jun 15, 2018

From @venkats:

In https://github.com/eclipse/microprofile-reactive/blob/master/streams/spec/src/main/asciidoc/architecture.asciidoc, under the Rationale section, in the paragraph that starts with "There are a number of different approaches..." the text reads: "...however users can select to use a custom implementation if they need." While this makes sense for the JDK implementation, does this make sense for MicroProfile implementation where 3-rd party dependency is not desired?

@jroper jroper added help wanted Extra attention is needed streams labels Jun 15, 2018
@jroper
Copy link
Member Author

jroper commented Jun 15, 2018

This is a good point, the API is already pluggable using the service loader mechanism, it doesn't necessarily need to be doubly pluggable. For the purposes of MicroProfile, I don't think we need the overload.

@jroper jroper added this to the streams-1.0 milestone Jun 19, 2018
@jroper jroper removed the streams label Aug 10, 2018
@jroper jroper modified the milestones: 1.0, 1.1 Sep 19, 2018
@Emily-Jiang
Copy link
Member

This is only used by tck.

@Emily-Jiang Emily-Jiang modified the milestones: 1.1, 2.0 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants