Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Error Handling #3

Open
alexhambley opened this issue Oct 1, 2024 · 0 comments
Open

Implement Error Handling #3

alexhambley opened this issue Oct 1, 2024 · 0 comments
Assignees
@alexhambley
Milestone
Establish Prototy...

Comments

@alexhambley
Copy link
Contributor

Begin centralised error handling for Cratey.

  • Should handle 400, 401, 404.
  • Return JSON responses for all errors.

Light touch in this first implementation.
@alexhambley alexhambley self-assigned this Oct 1, 2024
@alexhambley alexhambley moved this to In Progress in Internal Technical Backlog Dec 12, 2024
alexhambley added a commit that referenced this issue Jan 2, 2025
@alexhambley
refactor: celery_worker.py to configure Celery
c0d4f6d 
- Addresses #3, #24
- Introduced the make_celery function to configure a Celery instance using Flask application settings.
- Raises ValueError if config missing
alexhambley added a commit that referenced this issue Jan 3, 2025
@alexhambley
refactor: KeyError raised when parameters are missing
bfa157c 
- Addresses #3, #24
- Implement error handling when parameters are missing
alexhambley added a commit that referenced this issue Jan 6, 2025
@alexhambley
feat: Queue RO-Crate for validation with Celery
b69d742 
- Addresses #25, #3
- Sets up basic logging
- Sets up basic error handling
- Queues an RO crate for validation with process_validation_task_by_id.delay()
alexhambley added a commit that referenced this issue Jan 7, 2025
@alexhambley
feat: RO Crate Validation
028d81b 
- Addresses #6, #3
- process_validation_task_by_id() is a celery background task to call perform_ro_crate_validation(), update an RO Crate and send webhook.
- perform_ro_crate_validation() validates the RO Crate using the CRS4 validator.
alexhambley added a commit that referenced this issue Jan 8, 2025
@alexhambley
feat: fetch RO Crates from MinIO store
de7eace 
- Addresses #31, #3
- RO-Crate fetched from MinIO based on the provided crate ID
alexhambley added a commit that referenced this issue Jan 9, 2025
@alexhambley
feat: update object in MinIO with validation status
c231f2c 
- Addresses #32, #3
- update_validation_status_in_minio() will upload a txt file containing JSON validation result.
- Refactored module to introduce get_minio_client_and_bucket() and remove duplicate code fragment
- Type hinting and docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexhambley alexhambley

Labels
None yet
Projects
None yet
Milestone
Establish Prototype API service
Development

No branches or pull requests
1 participant
@alexhambley