Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum attachment size support - for one and all files #24

Open
KamilaHasanbega opened this issue Aug 17, 2016 · 2 comments
Open

Maximum attachment size support - for one and all files #24

KamilaHasanbega opened this issue Aug 17, 2016 · 2 comments

Comments

@KamilaHasanbega
Copy link
Contributor

The attached file(s) max size limit needs to be set at 25Mb (right now there is no size limit).

@KamilaHasanbega
Copy link
Contributor Author

KamilaHasanbega commented Aug 26, 2016

I made this work by stopping the attachments from being added, if filezise + array size of pervious attachments exceeds 25Mb, but now I have a few issues UI related:

  • I show the warning that the file(s) cannot be added once they exceed 25MB when the user tries to upload it/them below the attachment-send-cancel bar. (Is that the right behavior?)
  • As for now, I only disable the button once the previous files added, add up to 25MB, but that needs the file to be exactly 25 Mb otherwise it doesn't happen (as if < there is still space in the array) - Is that the right behavior regarding UI or should I set a range, say 24.5-25 mb -> attach button disabled? @koto @aesdeluca

@KamilaHasanbega
Copy link
Contributor Author

Fixed at #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant