Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issues #10

Open
kbsriram opened this issue Jul 22, 2016 · 3 comments
Open

Fix styling issues #10

kbsriram opened this issue Jul 22, 2016 · 3 comments

Comments

@kbsriram
Copy link
Contributor

With the new onboarding flow changes, the existing UI styles have been affected and need to be updated.

  • All text is centered
  • Buttons look too big
  • Hard to see the separators between threads/messages

bb
dd

@koto
Copy link
Contributor

koto commented Aug 8, 2016

This should fix most of those problems:

--- a/chrome/assets/css/bootstrap.css
+++ b/chrome/assets/css/bootstrap.css
@@ -808,7 +808,6 @@ pre code {
 }

 .row {
-  text-align: center;
   margin-right: -15px;
   margin-left: -15px;
 }
@@ -2238,7 +2237,6 @@ textarea.input-lg {
 .btn {
   display: inline-block;
   padding: 6px 12px;
-  margin: auto;
   margin-bottom: 0;
   font-size: 14px;
   font-weight: normal;
@@ -2330,8 +2328,6 @@ fieldset[disabled] .btn-default.active {
 }

 .btn-primary {
-  font-size: 20px;
-  padding-left: 12px 45px 12px 45px;
   color: #ffffff;
   background-color: #428bca;
   border-color: #357ebd;
@@ -7099,4 +7095,4 @@ td.visible-print {
   td.hidden-print {
     display: none !important;
   }
-}

But I'm waiting for #8 to be merged, as there are new style changes incoming.

@KamilaHasanbega
Copy link
Contributor

Hey @kbsriram, according to the UI for attachments, the position/ordering of buttons is slightly changing as well, therefore I scheduled the CSS changes together with the details about attachment icon and input, being both effected by each other. It's in the next CL.

@koto
Copy link
Contributor

koto commented Aug 31, 2016

These are fixed:

  • All text is centered
  • Buttons look too big

As for the separators between messages/threads, I'll fix them according to https://github.com/e2email-org/e2email/blob/05a24965c7bd97c75d5eada1857f222acf546ff7/screenshots/basic.png.

koto added a commit to koto/e2email that referenced this issue Sep 5, 2016
For messages and threads now the background is again white.

Fixes e2email-org#10, but small changes are still required for the outline around active form elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants