Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate bootstrap import #2365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove duplicate bootstrap import #2365

wants to merge 1 commit into from

Conversation

niklasmohrin
Copy link
Member

@niklasmohrin niklasmohrin commented Jan 13, 2025 •
edited
Loading

Closes #2362

This decreases the size of evap.css generated by ./manage.py scss --production from 585k to 357k.

@niklasmohrin
Remove duplicate bootstrap import
2e47ea2 
This decreases the size of `evap.css` generated by
    ./manage.py scss --production
from 585k to 357k.
richardebeling
richardebeling approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsi. Guess it's not a programming language :D

@niklasmohrin niklasmohrin requested a review from janno42 January 13, 2025 17:31
@niklasmohrin
Copy link
Member Author

Over a year of ODR violations in EvaP, one would think clang could figure this out ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakadus Kakadus Kakadus approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 Awaiting requested review from janno42

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap is included twice in evap.css
3 participants
@niklasmohrin @richardebeling @Kakadus