⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.28%. Comparing base (b7abe8f) to head (9a267f2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   65.19%   65.28%   +0.08%     
==========================================
  Files          50       50              
  Lines        8729     8737       +8     
  Branches     1034     1034              
==========================================
+ Hits         5691     5704      +13     
+ Misses       3038     3033       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Can this not be solved by installing the font in the relevant docker images. I'm guessing the issue is that those images dont have a good font installed that can be picked up by pango

Can this not be solved by installing the font in the relevant docker images. I'm guessing the issue is that those images dont have a good font installed that can be picked up by pango

yes that's the problem. however automated test done downstream by various distros doesn't pull a font. this is more of an hack, but I don't know if they can add some soft dependency on fonts in their ci.

@dcermak @fossdd as distro packager does this solution seem right to you? or is a soft dependency on fonts better ?

A distro test system should be able to configure dependencies for software I would think. Do distros use the dunst test suite to test their packages?

A distro test system should be able to configure dependencies for software I would think. Do distros use the dunst test suite to test their packages?

Yes but the problem is that we introduced a test that fails when no font is present. So all the old packaging started failing when updating to v1.12

the automatic ci runs for the distros started failing because they did not explicitly add the font dependency

For Alpine Linux it's totally fine to add a font to our test dependencies. Sounds easier to maintain than shipping a font in the tarball. It makes sense documenting this somewhere, like in HACKING.md.

I do agree with @fossdd, it's no problem to pull in a font as a build-time dependency, neither in Fedora nor in openSUSE. I would discourage bundling a font and instead document this requirement for the test suite

Ok let's do it that way then.
I'll close this proof of concept and add some lines to the dependencies documentation