-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dex_solana.sandwiches
& dex_solana.sandwiched
#6196
Conversation
Note the newly created Solana specific dbt subproject where these models should move to: #6197 |
you guys should inform us when stuff is moving to a diff dbt subprojects, not ideal to have to rework stuff on every single one of my PRs these days (only reason i have many open prs is because i cant work on one at a time given i need to wait for ci runs to finish since i cant test stuff locally + rerun them all for test tables on every new working day) i used macros here cause it was easier to port but sure i can make it a normal spell instead. would we be able to get macros working across dbt projects? even if not natively capable, there has to be a way to clone necessary yml files and macros across dbt subprojects, right? |
@hildobby sorry about the mess, we are getting close to being done. Regarding macros the top level |
oh this wasn't about this macro specifically but about stuff being available across subprojects, what folders exactly are shared across dbts? is it only macros? sources would also be cool for example |
currently sources and macro's are shared across projects! |
oh ok so its just that it's refs where it's built and needs to be defined as sources when used somewhere else? maybe all sources should be moved to their own folder that is shared across all projects then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
closing due to inactivity. feel free to reopen and describe what needs to happen next, if necessary. thank you. |
AND dt.tx_id=s.tx_id | ||
AND dt.project_program_id=s.project_program_id | ||
-- Adding block_number and tx_index to the mix, can be removed once those are in dex.trades | ||
INNER JOIN {{source('solana','transactions')}} tx ON tx.block_time=s.block_time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewhong5297 i was able to remove the join to this raw table, as solana dex has the two fields requested from what i can tell so i simply added in selects
@andrewhong5297 plz give final review with latest changes 🙏 |
Will need @hildobby to review the cte changes when he back from OOO |
sounds good, will leave in queue until approved |
lgtm @andrewhong5297, just added you as a contributor to the spell cc @jeff-dude |
sounds good, thanks! |
Thank you for contributing to Spellbook 🪄
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!