Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus Mutual - products & covers #6142

Merged
merged 13 commits into from
Jun 25, 2024

Conversation

tomfutago
Copy link
Contributor

@tomfutago tomfutago commented Jun 11, 2024

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s):
    • nexusmutual_ethereum_products_v1
    • nexusmutual_ethereum_product_types_v2
    • nexusmutual_ethereum_products_v2
    • nexusmutual_ethereum_covers_v1
    • nexusmutual_ethereum_covers_v2
  • Description: base spells retrieving products offered by Nexus Mutual & covers bought to date
  • Who are the new spell(s) for? internal team and/or general community
  • How will the new spell(s) be used downstream? improvements to existing dashboards
  • Implementation details: all new spells are materialised as views (except for one static table) and might need revisiting down the line to convert to incremental loads
  • Test instructions: no specific instructions here apart from CI taking care of implemented basic tests like columns nullability and uniqueness

@dune-eng
Copy link

Workflow run id 9469396960 approved.

@dune-eng
Copy link

Workflow run id 9469397197 approved.

@jeff-dude jeff-dude added the WIP work in progress label Jun 11, 2024
@dune-eng
Copy link

Workflow run id 9480071166 approved.

@dune-eng
Copy link

Workflow run id 9480070941 approved.

@dune-eng
Copy link

Workflow run id 9481038231 approved.

@dune-eng
Copy link

Workflow run id 9481038268 approved.

@dune-eng
Copy link

Workflow run id 9481438020 approved.

@dune-eng
Copy link

Workflow run id 9481438194 approved.

@dune-eng
Copy link

Workflow run id 9485706866 approved.

@dune-eng
Copy link

Workflow run id 9485707296 approved.

@dune-eng
Copy link

Workflow run id 9486157499 approved.

@dune-eng
Copy link

Workflow run id 9486157349 approved.

@dune-eng
Copy link

Workflow run id 9496771482 approved.

@dune-eng
Copy link

Workflow run id 9496771742 approved.

@tomfutago tomfutago marked this pull request as ready for review June 13, 2024 09:47
@tomfutago tomfutago marked this pull request as draft June 13, 2024 15:57
@dune-eng
Copy link

Workflow run id 9503305454 approved.

@dune-eng
Copy link

Workflow run id 9503305738 approved.

@tomfutago tomfutago marked this pull request as ready for review June 13, 2024 16:30
@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jun 17, 2024
@jeff-dude jeff-dude self-assigned this Jun 17, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jun 17, 2024
@jeff-dude
Copy link
Member

another consideration, but not a must:
if you expect to deploy on other chains, maybe it makes sense to reorg directory to models/nexusmutual/<use case>/<blockchain>/ so it's easier to stick to one area when navigating directories, rather than seeing multiple use cases with a chain directory. hopefully that makes sense 😅

@dune-eng
Copy link

Workflow run id 9561854472 approved.

@dune-eng
Copy link

Workflow run id 9561854575 approved.

@tomfutago
Copy link
Contributor Author

another consideration, but not a must: if you expect to deploy on other chains, maybe it makes sense to reorg directory to models/nexusmutual/<use case>/<blockchain>/ so it's easier to stick to one area when navigating directories, rather than seeing multiple use cases with a chain directory. hopefully that makes sense 😅

I like the idea with dir reorg, but there are no plans to deploy on other chains, so if it's only ethereum it probably makes more sense to keep all folders where they are. btw, more of them are coming soon..

@tomfutago
Copy link
Contributor Author

CI is not too happy last few days (on any PR not just this one), keeps blowing up on "Error listing tables for catalog hive msg..

@jeff-dude
Copy link
Member

CI is not too happy last few days (on any PR not just this one), keeps blowing up on "Error listing tables for catalog hive msg..

yeah, i'll have to investigate this one. the dbt run sends a bunch of queries to the db to "list" schemas for some reason prior to actually running anything. it appears to be getting stuck here

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, i'll keep trying CI. reruns have helped other PRs. we are working with our platform team on how to fix

@jeff-dude jeff-dude added ready-for-merging blocked and removed in review Assignee is currently reviewing the PR labels Jun 19, 2024
@jeff-dude
Copy link
Member

code looks good, i'll keep trying CI. reruns have helped other PRs. we are working with our platform team on how to fix

ugh. keeps happening. is this in a rush? can it wait until we find the resolution?

@tomfutago
Copy link
Contributor Author

code looks good, i'll keep trying CI. reruns have helped other PRs. we are working with our platform team on how to fix

ugh. keeps happening. is this in a rush? can it wait until we find the resolution?

not a massive rush, happy to wait

@jeff-dude
Copy link
Member

finally!

@jeff-dude jeff-dude removed the blocked label Jun 25, 2024
@jeff-dude jeff-dude merged commit c124b7c into duneanalytics:main Jun 25, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants