Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GIV token to ethereum prices #6137

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Add GIV token to ethereum prices #6137

merged 6 commits into from
Jun 18, 2024

Conversation

aminlatifi
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]
    Added Giveth (giveth.io) GIV token to the list of ethereum tokens.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dune-eng
Copy link

Workflow run id 9466403723 approved.

@dune-eng
Copy link

Workflow run id 9466403957 approved.

@dune-eng
Copy link

Workflow run id 9466404013 approved.

@aminlatifi aminlatifi mentioned this pull request Jun 11, 2024
Closed
@jeff-dude jeff-dude added WIP work in progress blocked labels Jun 11, 2024
@dune-eng
Copy link

Workflow run id 9534414426 approved.

@dune-eng
Copy link

Workflow run id 9534414327 approved.

@dune-eng
Copy link

Workflow run id 9534414405 approved.

@aminlatifi aminlatifi requested a review from jeff-dude June 16, 2024 07:55
@dune-eng
Copy link

Workflow run id 9534418243 approved.

@dune-eng
Copy link

Workflow run id 9534418284 approved.

@dune-eng
Copy link

Workflow run id 9534418285 approved.

@aminlatifi
Copy link
Contributor Author

@jeff-dude Can you rereview it? I think the problem is resolved.

@jeff-dude jeff-dude self-assigned this Jun 17, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed WIP work in progress blocked labels Jun 17, 2024
@jeff-dude
Copy link
Member

@jeff-dude Can you rereview it? I think the problem is resolved.

yep, token is good to go now. we just need you to sign the CLA in order to get it merged. please follow instructions from bot comment above. you just need to simply copy/paste that command in a comment on it's own

@aminlatifi
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@aminlatifi
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Jun 18, 2024
@github-actions
@aminlatifi has signed the CLA in #6137
b760f9b
@aminlatifi
Copy link
Contributor Author

@jeff-dude Can you rereview it? I think the problem is resolved.

yep, token is good to go now. we just need you to sign the CLA in order to get it merged. please follow instructions from bot comment above. you just need to simply copy/paste that command in a comment on it's own

Done. Thanks @jeff-dude

@dune-eng
Copy link

Workflow run id 9561681460 approved.

@dune-eng
Copy link

Workflow run id 9561681210 approved.

@dune-eng
Copy link

Workflow run id 9561681419 approved.

@dune-eng
Copy link

Workflow run id 9562058340 approved.

@dune-eng
Copy link

Workflow run id 9562058482 approved.

@dune-eng
Copy link

Workflow run id 9562058444 approved.

@dune-eng
Copy link

Workflow run id 9571536893 approved.

@dune-eng
Copy link

Workflow run id 9571537026 approved.

@dune-eng
Copy link

Workflow run id 9571537069 approved.

@aminlatifi
Copy link
Contributor Author

@jeff-dude The PR seems ready, I resolved the conflict with the latest version

jeff-dude
jeff-dude approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR blocked labels Jun 18, 2024
@jeff-dude jeff-dude merged commit 7aad216 into duneanalytics:main Jun 18, 2024
3 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Jun 18, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminlatifi @dune-eng @jeff-dude