Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solidly V3 to dex.trades #6115

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

ibilbobaggins
Copy link
Contributor

@ibilbobaggins ibilbobaggins commented Jun 7, 2024

Now it should be available in dex.trades

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

Copy link

github-actions bot commented Jun 7, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dune-eng
Copy link

dune-eng commented Jun 7, 2024

Workflow run id 9424429437 approved.

@dune-eng
Copy link

dune-eng commented Jun 7, 2024

Workflow run id 9424429667 approved.

@dune-eng
Copy link

dune-eng commented Jun 8, 2024

Workflow run id 9424504474 approved.

@dune-eng
Copy link

dune-eng commented Jun 8, 2024

Workflow run id 9424504597 approved.

@ibilbobaggins
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dune-eng
Copy link

dune-eng commented Jun 8, 2024

Workflow run id 9427509100 approved.

@dune-eng
Copy link

dune-eng commented Jun 8, 2024

Workflow run id 9427509142 approved.

@ibilbobaggins
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

recheck

@dune-eng
Copy link

dune-eng commented Jun 9, 2024

Workflow run id 9438529381 approved.

@dune-eng
Copy link

dune-eng commented Jun 9, 2024

Workflow run id 9438529494 approved.

@dune-eng
Copy link

Workflow run id 9444025865 approved.

@dune-eng
Copy link

Workflow run id 9444025997 approved.

@dune-eng
Copy link

Workflow run id 9444185009 approved.

@dune-eng
Copy link

Workflow run id 9444185191 approved.

@dune-eng
Copy link

Workflow run id 9445469334 approved.

@dune-eng
Copy link

Workflow run id 9445469166 approved.

@dune-eng
Copy link

Workflow run id 9445609274 approved.

@dune-eng
Copy link

Workflow run id 9445609633 approved.

@dune-eng
Copy link

Workflow run id 9445672909 approved.

@dune-eng
Copy link

Workflow run id 9445673396 approved.

@dune-eng
Copy link

Workflow run id 9450498110 approved.

@dune-eng
Copy link

Workflow run id 9450498334 approved.

@dune-eng
Copy link

Workflow run id 9451742656 approved.

@dune-eng
Copy link

Workflow run id 9451743264 approved.

@dune-eng
Copy link

Workflow run id 9455130368 approved.

@dune-eng
Copy link

Workflow run id 9455130816 approved.

@dune-eng
Copy link

Workflow run id 9462623407 approved.

@dune-eng
Copy link

Workflow run id 9462623635 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dune-eng
Copy link

Workflow run id 9464328484 approved.

@dune-eng
Copy link

Workflow run id 9464328742 approved.

@Hosuke Hosuke added dbt: dex covers the DEX dbt subproject ready-for-final-review labels Jun 11, 2024
@ibilbobaggins
Copy link
Contributor Author

@Hosuke Seems ready to merge I think.

@jeff-dude jeff-dude self-assigned this Jun 11, 2024
@jeff-dude jeff-dude merged commit 569b7ee into duneanalytics:main Jun 11, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Jun 11, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

GitPOAP: 2024 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants