paraswap: add paraswap_zkevm + v6.1 spell #6100
Conversation
|
Workflow run id 9400951741 approved. |
|
Workflow run id 9400951863 approved. |
|
Workflow run id 9400961897 approved. |
|
Workflow run id 9400962107 approved. |
|
Workflow run id 9412036634 approved. |
|
Workflow run id 9412036833 approved. |
|
Workflow run id 9414598097 approved. |
|
Workflow run id 9414598476 approved. |
|
Workflow run id 9427890743 approved. |
|
Workflow run id 9427890791 approved. |
|
Workflow run id 9428665135 approved. |
|
Workflow run id 9428665218 approved. |
mwamedacen
changed the title
mwamedacen
changed the title
Hosuke
added
in review
Co-authored-by: Huang Geyang <[email protected]>
Co-authored-by: Huang Geyang <[email protected]>
|
Workflow run id 9442458777 approved. |
|
Workflow run id 9442458858 approved. |
|
Workflow run id 9442460616 approved. |
|
Workflow run id 9442460771 approved. |
|
thanks for the suggestions, applied @Hosuke both. Worth noting that those improvements are not normalised across all the spells (not only ParaSwap ones) |
| AND tx.block_time >= TIMESTAMP '{{project_start_date}}' | ||
| {% endif %} | ||
| {% if is_incremental() %} | ||
| AND tx.block_time >= date_trunc('day', now() - interval '7' day) |
There was a problem hiding this comment.
| AND tx.block_time >= date_trunc('day', now() - interval '7' day) | |
| AND {{ incremental_predicate('tx.block_time') }} |
| AND p2.minute >= TIMESTAMP '{{project_start_date}}' | ||
| {% endif %} | ||
| {% if is_incremental() %} | ||
| AND p2.minute >= date_trunc('day', now() - interval '7' day) |
There was a problem hiding this comment.
| AND p2.minute >= date_trunc('day', now() - interval '7' day) | |
| AND {{ incremental_predicate('p2.minute') }} |
| AND p1.minute >= TIMESTAMP '{{project_start_date}}' | ||
| {% endif %} | ||
| {% if is_incremental() %} | ||
| AND p1.minute >= date_trunc('day', now() - interval '7' day) |
There was a problem hiding this comment.
| AND p1.minute >= date_trunc('day', now() - interval '7' day) | |
| AND {{ incremental_predicate('p1.minute') }} |
|
i've been letting this one sit, as it appears suggestion still remain. please do make the changes and look to finalize |
|
closing due to inactivity. feel free to reopen and describe what needs to happen next, if necessary. thank you. |
This PR is a follow up of previous works (copy pasta). Previous PRs: #5597 and #6002