-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing phoenix dex trades (merge after transfers PR) #6093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @andrewhong5297
This one has to wait until another pr is merged, just fyi! |
models/phoenix/schema.yml
Outdated
@@ -33,6 +33,9 @@ models: | |||
- &block_time | |||
name: block_time | |||
description: "UTC event block time of each DEX trade" | |||
- &block_slot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New columns introduced for phoenix_v1.trades
@jeff-dude @aalan3 I'm using a seed in the main project, do I need to move that seed over? or I call it as a source now or something instead? |
nvm got it |
SELECT | ||
market_id | ||
, cast(raw_base_units_per_base_unit as int) as raw_base_units_per_base_unit | ||
FROM {{ ref('phoenix_solana_market_metadata') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prod failed due to this ref not existing.
looks like it's a reference to a seed in PR below.
why are we using a seed as a reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I forgot we aren't materializing the seeds in prod. :/
From the comment at L152:
(l.tokenA_filled*coalesce(mm.raw_base_units_per_base_unit,1)) --base unit can be adjusted by phoenix, i.e. for BONK it starts at 1e6. There is a script for updating the markets seed file.
@andrewhong5297 can you convert this to a values model as we do for other static datasets?
part of solana dex trades overhaul