Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the filter apply on desktop too? #3

Open
mudrd8mz opened this issue Jun 14, 2019 · 1 comment
Open

Should the filter apply on desktop too? #3

mudrd8mz opened this issue Jun 14, 2019 · 1 comment

Comments

@mudrd8mz
Copy link

Is it intended that the filter applies all the time, even the user is not on a mobile device? Should it somehow try to detect the user's device type and not apply on desktops?

@dpalou
Copy link
Owner

dpalou commented Jun 17, 2019

Hi David,

the Moodle desktop app can also be launched with these links (except in Linux), so IMO it should be applied in desktop too.

I'll keep the issue open for now, it could be interesting to add a new option to apply the filter only on Mobile. E.g. most of our branded apps only have a mobile version, so they probably won't want to apply the filter in desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants