Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsnEncodedDataTests fail on Debian 13 #111818

Closed
richlander opened this issue Jan 24, 2025 · 5 comments · Fixed by #111820
Closed

AsnEncodedDataTests fail on Debian 13 #111818

richlander opened this issue Jan 24, 2025 · 5 comments · Fixed by #111820
Assignees
@bartonjs
Labels
area-System.Security blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab
Milestone
10.0.0

Comments

@richlander
Copy link
Member

richlander commented Jan 24, 2025 •
edited by build-analysis bot
Loading

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=927317
Build error leg or test failing: System.Security.Cryptography.Tests.AsnEncodedDataTests.TestSubjectAlternativeName_Unix
Pull request: #111768

Error Message

Fill the error message using step by step known issues guidance.

Exception Message:

Assert.Equal() Failure: Strings differ
                          ↓ (pos 15)
Expected: "othername: UPN::[email protected], "···
Actual:   "othername: UPN:[email protected], e"···
                          ↑ (pos 15)

CallStack:

   at System.Security.Cryptography.Tests.AsnEncodedDataTests.TestSubjectAlternativeName_Unix() in /_/src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs:line 147
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args) in /_/src/mono/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.Mono.cs:line 22
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflect

I did some searched for ASN breaking changes and didn't see anything.

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@richlander richlander added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Jan 24, 2025
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 24, 2025
@bartonjs
Copy link
Member

openssl/openssl@de8861a removed the redundant colon, so we need yet another OSSL-version check in the tests... 3.4 and higher are better formatted.

runtime/src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs

Line 119 in cedf4e2

isOpenSsl3 ? "othername: UPN::[email protected]" : "othername:<unsupported>",

@bartonjs bartonjs added area-System.Security and removed untriaged New issue has not been triaged by the area owner labels Jan 24, 2025
@bartonjs bartonjs added this to the 10.0.0 milestone Jan 24, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@richlander
Copy link
Member Author

richlander commented Jan 24, 2025 •
edited
Loading

Thanks for finding the change. That's great.

Can you make the change, preferably in my branch? I can give you access.

Will we need to backport this change?

@bartonjs
Copy link
Member

Will we need to backport this change?

Assuming we care about running older version tests on Debian 13 (or any other distro that upgrades to OSSL 3.4), yes

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 25, 2025
@richlander
Copy link
Member Author

It would be best. Debian 12 will go out of support before .NET 8 does at which point we will need to move to Debian 13 (at the latest). Both Debian and .NET are on a 3 year support model and Debian always ships a few months earlier. We can skip .NET 9, however. Up to you folks.

@bartonjs bartonjs mentioned this issue Jan 25, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartonjs bartonjs

Labels
area-System.Security blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Handle OSSL 3.4 change to SAN:othername formatting bartonjs/runtime
3 participants
@vcsjones @richlander @bartonjs