Avoid overwriting request's params with silk params #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a request have params of its own (given by `ring.middlewares.params.wrap-params`, for example), they should not be deleted or overwritten by `ring-handler`. This commit makes sure `silk` params are merged with any possible existing request's params.
|
Hmm not sure why that failed. I ran |
| @@ -34,7 +34,7 @@ | |||
| (fn [req] | |||
| (if-let [params (silk/match rtes (request-map->URL req))] | |||
| ((-> params :domkm.silk/name get-handler) | |||
| (assoc req :params params)) | |||
| (merge-with merge req {:params params})) | |||
There was a problem hiding this comment.
Try (update req :params merge params)
|
done @domkm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ring request's
:paramswere overwritten byring-handler, whichassocits params in the request.This scenario might be a common one, specially if the user is using something like
ring.middlewares.params.wrap-params, for example.This PR makes sure silk
:paramsare merged to any possible existing request's:params.I wrote a test for it, let me know if it's enough or if I should test or improve anything else.
Closes #21