Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit use of rpcerror.Unknown #20

Open
jmalloc opened this issue Sep 24, 2021 · 0 comments
Open

Audit use of rpcerror.Unknown #20

jmalloc opened this issue Sep 24, 2021 · 0 comments
Milestone
0.2.0

Comments

@jmalloc
Copy link
Member

jmalloc commented Sep 24, 2021

  • It might be better named as Unspecified, as what it really communicates is that the details of the error are unimportant to the client.
  • There's probably cause for an equivalent to HTTP's 400 Bad Request, as I think rpcerror.Unknown is currently used when the client misuses the API in some way.
@jmalloc jmalloc added this to the 0.2.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@jmalloc