Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail action on unsupported architecture #158

Open
3 tasks done
jacob-carlborg opened this issue Aug 1, 2024 · 1 comment
Open
3 tasks done

Fail action on unsupported architecture #158

jacob-carlborg opened this issue Aug 1, 2024 · 1 comment

Comments

@jacob-carlborg
Copy link

jacob-carlborg commented Aug 1, 2024

Contributing guidelines

I've found a bug, and:

  • The documentation does not mention anything about my problem
  • There are no open or closed issues that are related to my problem

Description

The action continues to run when an unsupported architecture is specified. The problem is that I specified mips64el as the architecture instead of mips64le.

Expected behaviour

I expected the action to fail.

Actual behaviour

The action continues to run an completes successfully.

Repository URL

https://github.com/jacob-carlborg/lime

Workflow run URL

https://github.com/jacob-carlborg/lime/actions/runs/10162079184/job/28101982775

YAML workflow

- name: Set up QEMU
        uses: docker/setup-qemu-action@v3
        with:
          platforms: mips64el

Workflow logs

No response

BuildKit logs

No response

Additional info

No response

@crazy-max
Copy link
Member

crazy-max commented Aug 1, 2024

Agreed, we should fail in such case: https://github.com/jacob-carlborg/lime/actions/runs/10162079184/job/28101982775#step:6:195

  /usr/bin/docker run --rm --privileged docker.io/tonistiigi/binfmt:latest --install mips64el
  installing: mips64el unsupported architecture: mips64el

image

Should be fixed upstream https://github.com/tonistiigi/binfmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants