general reprojection changes #775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #772
some changes to make
WorkUnithandle the general reprojection case (i.e. when there's a non-ebd wcs that we're resampling to).Changes
image_positions_to_original_icrsto handle when common wcs isn't in ebdreprojection_frameparameter toWorkUnitDesign
Putting this in draft because there's still an open design question (at least in my mind) over whether or not there should be a single canonical frame parameter in
WorkUnit. As discussed in #772, we can eitherWorkUnithas ebd wcses attached to itreprojection_frameparameter as a source of truthI went with number two, as it handles the every case and could help us keep everything in order in the future, but it has the con that it's not totally backwards compatible. There's a work around to make sure it doesn't break any older
WorkUnits by checking if the frame metadata parameter in the fits header exists but that could lead to weird states for some of our currently existing data. This is a bad pattern that I've tried avoiding in the past withWorkUnit, but it's also a relatively minor problem we're solving so I think it's fine to let it slide this time.