From 77d5b9bbbe36123b49ee6191a4d5a55f24483304 Mon Sep 17 00:00:00 2001
From: Hannes Michalek <hannes.michalek@digitalservice.bund.de>
Date: Thu, 9 Jan 2025 13:57:15 +0100
Subject: [PATCH] Explicitly use ubuntu-24.04 to try and see the consequences

The 24.04 will become the default soon, cf. https://github.com/actions/runner-images/issues/10636
---
 .github/workflows/frontend-build-image-and-scan.yml  |  4 ++--
 .github/workflows/frontend-checks.yml                | 12 ++++++------
 .github/workflows/frontend-deploy-staging.yml        |  2 +-
 .../workflows/frontend-push-image-to-registry.yml    |  2 +-
 .github/workflows/security-jobs.yml                  |  4 ++--
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/frontend-build-image-and-scan.yml b/.github/workflows/frontend-build-image-and-scan.yml
index 486a9e8..a28792c 100644
--- a/.github/workflows/frontend-build-image-and-scan.yml
+++ b/.github/workflows/frontend-build-image-and-scan.yml
@@ -16,7 +16,7 @@ on:
 
 jobs:
   frontend-build-image-and-scan:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - name: Build frontend image
@@ -107,4 +107,4 @@ jobs:
         uses: digitalservicebund/notify-on-failure-gha@814d0c4b2ad6a3443e89c991f8657b10126510bf # v1.5.0
         if: ${{ failure() && github.ref == 'refs/heads/main' }}
         with:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
\ No newline at end of file
+          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
diff --git a/.github/workflows/frontend-checks.yml b/.github/workflows/frontend-checks.yml
index a967f08..5293be2 100644
--- a/.github/workflows/frontend-checks.yml
+++ b/.github/workflows/frontend-checks.yml
@@ -3,7 +3,7 @@ on:
 
 jobs:
   lint-and-format-check-frontend:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup Node
@@ -39,7 +39,7 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
 
   build-frontend:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup Node
@@ -72,7 +72,7 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
 
   unit-test-frontend:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup Node
@@ -113,7 +113,7 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
 
   e2e-test-frontend:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     container:
       image: mcr.microsoft.com/playwright:v1.49.1-noble
       options: --user 1001
@@ -157,7 +157,7 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
 
   code-quality-check-with-sonarqube:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
         with:
@@ -196,7 +196,7 @@ jobs:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
 
   license-audit-frontend:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
       - name: Setup Node
diff --git a/.github/workflows/frontend-deploy-staging.yml b/.github/workflows/frontend-deploy-staging.yml
index 674c646..77eed74 100644
--- a/.github/workflows/frontend-deploy-staging.yml
+++ b/.github/workflows/frontend-deploy-staging.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   deploy-staging:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     concurrency:
       group: deploy-staging
       cancel-in-progress: true
diff --git a/.github/workflows/frontend-push-image-to-registry.yml b/.github/workflows/frontend-push-image-to-registry.yml
index 08e4896..1c2e5f4 100644
--- a/.github/workflows/frontend-push-image-to-registry.yml
+++ b/.github/workflows/frontend-push-image-to-registry.yml
@@ -16,7 +16,7 @@ on:
 
 jobs:
   frontend-push-image-to-registry:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/cache@v4
         with:
diff --git a/.github/workflows/security-jobs.yml b/.github/workflows/security-jobs.yml
index 6428ed5..b8eec98 100644
--- a/.github/workflows/security-jobs.yml
+++ b/.github/workflows/security-jobs.yml
@@ -3,7 +3,7 @@ on:
 
 jobs:
   security-scan-with-trivy: # open source security scanner, cf. https://trivy.dev/
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -39,7 +39,7 @@ jobs:
       # cf https://digitalservicebund.atlassian.net/browse/RISDEV-5193
 
   secrets-scan-with-talisman: # scan for secrets that were published by mistake (we have a pre-commit and pre-push hook, but who knows)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     # Running on main only https://digitalservicebund.slack.com/archives/C046VD44ZEH/p1706516240974409
     #  if: ${{ github.ref == 'refs/heads/main' }}
     steps: