Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #2

Open
1 of 6 tasks
davidlehn opened this issue Feb 21, 2020 · 0 comments
Open
1 of 6 tasks

TODO #2

davidlehn opened this issue Feb 21, 2020 · 0 comments

Comments

@davidlehn
Copy link
Member

davidlehn commented Feb 21, 2020

Thanks for starting this. Some possible improvements:

  • Add some common README text. Probably using the https://github.com/RichardLitt/standard-readme format we've used elsewhere.
  • test/ has copies of top-level files. Remove the cruft.
  • Add a logger in lib/http.js or via a lib/logger.js.
  • Should we use a bedrock- prefix for the config namepace like bedrock-MODULE-http? (Probably shouldn't say profile as it does now.)
  • Perhaps in all the files, change module name to bedrock-MODULE-http or bedrock-FIXME-http so it's a bit easier to see what to update.
  • Should the template repo naming pattern be bedrock-module-template-http? Or would a common -template suffix work better? bedrock-module-http-template, bedrock-module-template, bedrock-web-module-template etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant