Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Loading P2 - 3: Only process new resources through the pipeline #235

Open
cjohns-scottlogic opened this issue Jan 16, 2025 · 0 comments

Comments

@cjohns-scottlogic
Copy link
Contributor

Having determined which downloaded resources are new (rather than ones that have been also been downloaded previously) update the pipeline to only process those resources.

This step is done by the collection-pipeline-makerules step, which will need to be updated to only emit makerules for the new resources, based on the contents of the new resources file created by the work from the previous ticket.

If the file is not present or otherwise cannot be read, rules will be emitted for all downloaded resources and a warning message printed.

Tech Approach
Update digital-land-python to only emit the required rules.

Acceptance critra
The appropriate pipeline.mk file is generated with either the new resources in (incremental loading active) or all resources (incremental loading disables or no new resources list available).

Note
If this work is deployed before the dataset update ticket, care must be taken to ensure that rules for each resource are emitted. With this in mind, it may be better to deploy both of these tickets together. However the work has been split as they are largely independent pieces.

@cjohns-scottlogic cjohns-scottlogic converted this from a draft issue Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant