Ensure column order in table view #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rosado
force-pushed
the
rosado/755-column-order
branch
from
d359850 to
a814866
Compare
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
test/unit/middleware/dataview.middleware.test.js (1)
122-122: Add additional test cases for edge scenariosThe current test suite would benefit from additional test cases to verify:
- Behaviour when neither 'name' nor 'reference' fields exist
- Behaviour when only one of the fields exists
- Order preservation of remaining fields
Here's an example of additional test cases:
it('preserves existing order when name and reference fields are absent', () => { const req = { entities: [{ id: 1, foo: 'bar', baz: 'qux' }], uniqueDatasetFields: ['foo', 'baz'] } const res = {} const next = vi.fn() constructTableParams(req, res, next) expect(req.tableParams.columns).toEqual(['foo', 'baz']) expect(req.tableParams.fields).toEqual(['foo', 'baz']) }) it('handles single leading field correctly', () => { const req = { entities: [{ id: 1, name: 'First', foo: 'bar' }], uniqueDatasetFields: ['foo', 'name'] } const res = {} const next = vi.fn() constructTableParams(req, res, next) expect(req.tableParams.columns).toEqual(['name', 'foo']) expect(req.tableParams.fields).toEqual(['name', 'foo']) })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/middleware/dataview.middleware.js(1 hunks)test/unit/middleware/dataview.middleware.test.js(1 hunks)
🔇 Additional comments (1)
test/unit/middleware/dataview.middleware.test.js (1)
110-122: Fix typo and enhance test coverageThe test case has the same issues as previously identified:
- Typo in the description: 'refernce' should be 'reference'
- Test should verify both 'name' and 'reference' columns
- Test data could be more comprehensive
Apply the suggested fix from the previous review to address these issues.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR ensures the "name" and "reference" columns come first in the table view.
Related Tickets & Documents
Closes #755
QA Instructions, Screenshots, Recordings
From what I can see the column order matches the desired one, but mostly by happy accident than anything else.
Added/updated tests?
QA sign off
Summary by CodeRabbit
New Features
Tests
These changes improve the organisation of dataset fields during table rendering, ensuring consistent and predictable column ordering.