From 1727cc82510bd1bd8d039571b2e1750b71ecb94f Mon Sep 17 00:00:00 2001 From: CarlosCoelhoSL Date: Mon, 2 Dec 2024 12:38:53 +0000 Subject: [PATCH] removes unnecessary pipeline_dir fixtures --- tests/acceptance/test_add_data.py | 9 --------- tests/integration/test_add_data.py | 13 ++----------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/tests/acceptance/test_add_data.py b/tests/acceptance/test_add_data.py index d38f035e..2cdf96cd 100644 --- a/tests/acceptance/test_add_data.py +++ b/tests/acceptance/test_add_data.py @@ -16,12 +16,6 @@ def specification_dir(tmp_path_factory): return specification_dir -@pytest.fixture(scope="function") -def pipeline_dir(tmp_path_factory): - pipeline_dir = tmp_path_factory.mktemp("pipeline") - return pipeline_dir - - @pytest.fixture(scope="function") def collection_dir(tmp_path_factory): collection_dir = tmp_path_factory.mktemp("collection") @@ -136,7 +130,6 @@ def create_input_csv( def test_cli_add_data( collection_dir, specification_dir, - pipeline_dir, organisation_csv, mock_request_get, monkeypatch, @@ -177,7 +170,6 @@ def test_cli_add_data( def test_cli_add_data_incorrect_input_data( collection_dir, specification_dir, - pipeline_dir, organisation_csv, mock_request_get, ): @@ -216,7 +208,6 @@ def test_cli_add_data_incorrect_input_data( def test_cli_add_data_consecutive_runs( collection_dir, specification_dir, - pipeline_dir, organisation_csv, mock_request_get, monkeypatch, diff --git a/tests/integration/test_add_data.py b/tests/integration/test_add_data.py index 00d693c2..95c14d26 100644 --- a/tests/integration/test_add_data.py +++ b/tests/integration/test_add_data.py @@ -16,12 +16,6 @@ def specification_dir(tmp_path_factory): return specification_dir -@pytest.fixture(scope="function") -def pipeline_dir(tmp_path_factory): - pipeline_dir = tmp_path_factory.mktemp("pipeline") - return pipeline_dir - - @pytest.fixture(scope="function") def collection_dir(tmp_path_factory): collection_dir = tmp_path_factory.mktemp("collection") @@ -136,7 +130,6 @@ def create_input_csv( def test_validate_and_add_data_input_no_error( collection_dir, specification_dir, - pipeline_dir, organisation_csv, caplog, mock_request_get, @@ -166,7 +159,7 @@ def test_validate_and_add_data_input_no_error( def test_validate_and_add_data_input_missing_columns( - collection_dir, specification_dir, pipeline_dir, organisation_csv, mock_request_get + collection_dir, specification_dir, organisation_csv, mock_request_get ): collection_name = "conservation-area" missing_column_input_data = { @@ -340,7 +333,6 @@ def test_validate_and_add_data_input_missing_columns( def test_validate_and_add_data( collection_dir, specification_dir, - pipeline_dir, organisation_csv, mock_request_get, input_data, @@ -360,7 +352,7 @@ def test_validate_and_add_data( def test_validate_and_add_data_input_non_200( - collection_dir, specification_dir, pipeline_dir, organisation_csv, capsys, mocker + collection_dir, specification_dir, organisation_csv, capsys, mocker ): mock_response = Mock() @@ -399,7 +391,6 @@ def test_validate_and_add_data_input_non_200( def test_validate_and_add_data_input_duplicate_endpoint( collection_dir, specification_dir, - pipeline_dir, organisation_csv, capsys, mock_request_get,