Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextualBody identifiers #301

Open
stephenwf opened this issue Nov 21, 2024 · 0 comments
Open

TextualBody identifiers #301

stephenwf opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@stephenwf
Copy link
Member

Currently the id property inside of a TextualBody annotation prevent Manifests from being validated. It is valid to have an identifier, but it is not required - so the Manifest Editor could still remove it when serialising the P3 resource.

The relevant code is here:
https://github.com/IIIF-Commons/parser/blob/main/src/presentation-3/serialize-presentation-3.ts#L17-L18

Where we do remove the ID if it was generated internally entity.id?.startsWith('vault://') - so when creating an HTML Body:

https://github.com/digirati-co-uk/iiif-manifest-editor/blob/main/packages/creators/src/ContentResource/HTMLBodyCreator/create-html-body.tsx#L15

We should make sure the ID is prefixed with vault:// if we want to ensure it's removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant