StringIndexOutOfBoundsException

[jilen]

java.lang.StringIndexOutOfBoundsException: String index out of range: 98
    java.lang.AbstractStringBuilder.deleteCharAt(AbstractStringBuilder.java:762)
    java.lang.StringBuilder.deleteCharAt(StringBuilder.java:258)
    com.google.sitebricks.StringBuilderRespond.chew(StringBuilderRespond.java:81)
    com.google.sitebricks.rendering.control.EmbeddedRespond.chew(EmbeddedRespond.java:100)
    com.google.sitebricks.rendering.control.XmlWidget.writeOpenTag(XmlWidget.java:115)
    com.google.sitebricks.rendering.control.XmlWidget.render(XmlWidget.java:72)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.XmlWidget.render(XmlWidget.java:79)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.EmbedWidget.render(EmbedWidget.java:66)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.XmlWidget.render(XmlWidget.java:79)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.DecorateWidget.render(DecorateWidget.java:57)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.XmlWidget.render(XmlWidget.java:79)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.XmlWidget.render(XmlWidget.java:79)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.rendering.control.XmlWidget.render(XmlWidget.java:79)
    com.google.sitebricks.rendering.control.ProceedingWidgetChain.render(ProceedingWidgetChain.java:21)
    com.google.sitebricks.routing.WidgetRoutingDispatcher.bindAndRespond(WidgetRoutingDispatcher.java:121)
    com.google.sitebricks.routing.WidgetRoutingDispatcher.dispatch(WidgetRoutingDispatcher.java:75)
    com.google.sitebricks.SitebricksFilter.doFilter(SitebricksFilter.java:59)
    com.google.inject.servlet.FilterDefinition.doFilter(FilterDefinition.java:163)
    com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:58)
    com.google.sitebricks.HiddenMethodFilter.doFilter(HiddenMethodFilter.java:70)
    com.google.inject.servlet.FilterDefinition.doFilter(FilterDefinition.java:163)
    com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:58)
    com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:118)
    com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:113)

[jilen]

This issue appears rarely.

[kidogo]

This issue is cause by EmbeddedRespondFactory using single instance of com.google.sitebricks.StringBuilderRespond, and therefore a single instance of StringBuilder in different requests/threads.

This causes the StringIndexOutOfBoundsException, and some other times cause output for one page to be currupted with output from other page instances.

A work arround is to replace EmbeddedRespondFactory with

@Immutable class EmbeddedRespondFactory {
  //private final Respond respond = new StringBuilderRespond(new Object());

  public EmbeddedRespond get(Map<String, ArgumentWidget> arguments) {
      final Respond respond = new StringBuilderRespond(new Object());
    return new EmbeddedRespond(arguments, respond);
  }
}