Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS compilation errors after upgrading to Expo SDK 44 #22

Open
kevgrig opened this issue Dec 26, 2021 · 2 comments
Open

iOS compilation errors after upgrading to Expo SDK 44 #22

kevgrig opened this issue Dec 26, 2021 · 2 comments

Comments

@kevgrig
Copy link

kevgrig commented Dec 26, 2021

Compilation used to work fine in Expo SDK 43. Also, the React Native version didn't change, so I guess it's either some new way Expo is building bare projects or an update to XCode.

/Users/test/Desktop/test/src/testexpoapp/node_modules/react-native-image-rotate/RNImageRotate/ImageRotateModule.m:35:12: Definition of 'RCTBridge' must be imported from module 'React.RCTBridge' before it is required
/Users/test/Desktop/test/src/testexpoapp/ios/Pods/Headers/Public/React-Core/React/RCTBridge.h:170:12: Definition here is not reachable
/Users/test/Desktop/test/src/testexpoapp/node_modules/react-native-image-rotate/RNImageRotate/ImageRotateModule.m:35:12: Property 'imageLoader' not found on object of type 'RCTBridge *'
/Users/test/Desktop/test/src/testexpoapp/node_modules/react-native-image-rotate/RNImageRotate/ImageRotateModule.m:65:14: Property 'imageStoreManager' not found on object of type 'RCTBridge *'

@kevgrig
Copy link
Author

kevgrig commented Dec 26, 2021

Seems to be resolved with:

diff --git a/RNImageRotate/ImageRotateModule.m b/RNImageRotate/ImageRotateModule.m
index 89ec4de..1b3010f 100644
--- a/RNImageRotate/ImageRotateModule.m
+++ b/RNImageRotate/ImageRotateModule.m
@@ -5,10 +5,10 @@
 #import <React/RCTConvert.h>
 #import <React/RCTLog.h>
 #import <React/RCTUtils.h>
-#import "RCTImageUtils.h"
+#import <React/RCTImageUtils.h>
 
-#import "RCTImageStoreManager.h"
-#import "RCTImageLoader.h"
+#import <React/RCTImageStoreManager.h>
+#import <React/RCTImageLoader.h>
 
 @implementation ImageRotateModule
 

@kevgrig
Copy link
Author

kevgrig commented Dec 26, 2021

Similar issues with callstack/react-native-image-editor#102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant