Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-actions-build] Couldn't open keymap file #330

Open
nistvan86 opened this issue May 20, 2023 · 6 comments
Open

[github-actions-build] Couldn't open keymap file #330

nistvan86 opened this issue May 20, 2023 · 6 comments

Comments

@nistvan86
Copy link

nistvan86 commented May 20, 2023

I was about to test win64 build at https://github.com/dethrace-labs/dethrace/actions/runs/5019323827
If I enter the configuration menu and try to change to any of the layouts the game crashes, and in the log I can see an error.

Failed to open "d:\tmp\dethrace/DATA/KEYMAP_0.TXT"Couldn't open Key Map file

This works with the same game files if I replace it with the 0.6.0 release of dethrace.

@nistvan86 nistvan86 changed the title [actions-build] Couldn't open keymap file [github-actions-build] Couldn't open keymap file May 20, 2023
@madebr
Copy link
Collaborator

madebr commented May 20, 2023

Can you try the executable that is built by the actions of #331?
It won't fix the error, but should print more information about why the file could not be opened.

It might also be useful to tell us what steps you're doing in dethrace, as detailed as possible.

@nistvan86
Copy link
Author

nistvan86 commented May 20, 2023

Failed to open "d:\tmp\dethrace/DATA/KEYMAP_0.TXT" (Permission denied)
Couldn't open Key Map file

This is rather strange as I do nothing else than overwriting the three files coming from the zip inside the game folder. I do the same restoring with the 0.6.0 zip and it starts to work correctly again.

Interestingly enough it still fails with permission denied if I launch the newer exe it with admin privileges.

@madebr
Copy link
Collaborator

madebr commented May 20, 2023

I can reproduce the error on Linux when I make DATA/KEYMAP_0.TXT read-only (chmod a-w KEYMAP_*.TXT).
Can you verify the file permissions?

@nistvan86
Copy link
Author

nistvan86 commented May 20, 2023

I see nothing out of ordinary with the files, authenticated users on the system have full access over them.

As I've said I'm using the exact same game files with the 0.6.0 and the github built version, I'm only replacing dethrace.exe, dethrace.pdb, sdl2.dll files in the game directory with either zip variant. With 0.6.0 it can load the keymap, with the other one it cannot. The game files are from the GoG installer of the game.
Actually it's enough to swap the dethrace.exe, as it still launches with the 0.6.0 dethrace.pdb and sdl2.dll files, this already shows this symptom.

I've checked and no other dethrace.exe is running on the system. Also tried adding the whole folder to Windows Defender's exclusion list but it still doesn't work. (I think it would completely block the execution if it finds it malicious, not just selective block some operations)

Now that I've checked it's not just the keymap file, but also the save games. It just don't crash the game when I try to save the game, but the next time I go to load game, it reverts back to the previous state in that slot.

I'm out of ideas what this could be.

@Squall-Leonhart
Copy link

Definitely an issue introduced with more recent changes, I'll start bisecting once i get the build environment setup.

@Squall-Leonhart
Copy link

Can be closed, it was fixed by #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants