You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently if command prefixed with sudo fails, deployer will retry it with "sudo ask pass" feature. That also happens if error happens in subcommand:
[devel] run sudo supervisorctl restart all
[devel] error in deploy.php on line 66:
[devel] run SUDO_ASKPASS=/var/www/comet/.dep/sudo_pass PASSWORD='' sudo -A supervisorctl restart all
[devel] mercure: stopped
[devel] mercure: ERROR (spawn error)
I think, it should only retry if failure comes from sudo command itself (password required etc).
Idea would be to check if sudo some_command stderr contains "sudo:" substring.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Deployer Version
7.4.X
Target OS
Ubuntu 24.04
Which PHP version are you using?
PHP 8.4
Content of deploy.php or deploy.yaml
No response
Steps to reproduce
Currently if command prefixed with sudo fails, deployer will retry it with "sudo ask pass" feature. That also happens if error happens in subcommand:
I think, it should only retry if failure comes from sudo command itself (password required etc).
Idea would be to check if
sudo some_command
stderr contains "sudo:" substring.Beta Was this translation helpful? Give feedback.
All reactions