Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions update fails when action is pinned to commit hash #11253

Open
1 task done
ReenigneArcher opened this issue Jan 8, 2025 · 7 comments
Open
1 task done
Labels
L: github:actions GitHub Actions L: go:modules Golang modules T: bug 🐞 Something isn't working

Comments

@ReenigneArcher
Copy link

ReenigneArcher commented Jan 8, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

github actions

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

https://github.com/LizardByte/.github/blob/49fb24e93d5902e16a7acce645932bd08fc643f6/.github/workflows/issues-stale.yml#L62

dependabot.yml content

https://github.com/LizardByte/.github/blob/49fb24e93d5902e16a7acce645932bd08fc643f6/.github/dependabot.yml#L22

Updated dependency

existing: amenocal/stale@44df11e

there is no update available

What you expected to see, versus what you actually saw

Do not error, or at least continue with other updates. OR... Continue working with commit hashes as used to work.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

image

https://github.com/LizardByte/.github/actions/runs/12666467352/job/35297906417

Similar issue, but closed by OP: #11181
Created discussion here, got no response: #11205 (behavior is slightly different now as at least I can see the error)

Smallest manifest that reproduces the issue

No response

@ReenigneArcher ReenigneArcher added the T: bug 🐞 Something isn't working label Jan 8, 2025
@github-actions github-actions bot added L: github:actions GitHub Actions L: go:modules Golang modules labels Jan 8, 2025
@laughedelic
Copy link

We encountered this problem in our organization as well. In our case, it failed on a GHA repository that is kept in another org from the same enterprise account (internal visibility).

I agree that Dependabot should fail gracefully and continue with other updates.

Screenshot 2025-01-09 at 14 36 57

@ReenigneArcher
Copy link
Author

The repository that failed for me is not a private repository.

It makes sense why it would fail in your case unless you provided it a PAT. https://docs.github.com/en/code-security/dependabot/working-with-dependabot/configuring-access-to-private-registries-for-dependabot#git

@ReenigneArcher ReenigneArcher changed the title github actions update fails github actions update fails when action is pinned to commit hash Jan 9, 2025
@gionn
Copy link

gionn commented Jan 9, 2025

I had a public repo with an action without any tag. Creating a semver compatibile tag fixed the issue on all the downstream repo.

Looks like it's a regression, won't be possibile to get updates unless there is a tag on the repo which is serving that action.

@ReenigneArcher
Copy link
Author

Hopefully this can be reconsidered. There are valid reasons to use a commithash versus a tagged version.

  • using a fork or unmerged branch temporarily to fix an issue
  • github allows hashes versus tags, so dependabot should also support that (at a minimum don't fail the rest of the updates)

I guess I may need to finally switch to renovate-bot.

@bartsmykla
Copy link

This issue is happening for us with two public actions. It looks like actions pinned to commit hashes with a semantic version tag can’t be used anymore.

@laughedelic
Copy link

@ReenigneArcher, I added my case here because it wasn't failing like this before. Even if it's a valid failure (which is arguable, but out of scope for this issue), it shouldn't block the rest of the updates.

@ReenigneArcher
Copy link
Author

ReenigneArcher commented Jan 15, 2025

I think I've tracked it down to this PR. #11144

Seems that it was reverted, but maybe not available in a release yet. #11289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: github:actions GitHub Actions L: go:modules Golang modules T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

4 participants