Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return types in schedule.ts #1454

Closed
cmwylie19 opened this issue Nov 20, 2024 · 0 comments · Fixed by #1505
Closed

Return types in schedule.ts #1454

cmwylie19 opened this issue Nov 20, 2024 · 0 comments · Fixed by #1505
Assignees
@cmwylie19
Labels
tech-debt
Milestone
v0.42.0

Comments

@cmwylie19
Copy link
Collaborator

Describe what should be investigated or refactored

We decided to encourage return types. We are looking to complete this task over several steps. In this case it is the schedule.ts and schedule.test.ts

#1364
@cmwylie19 cmwylie19 added this to the v0.41.0 milestone Nov 20, 2024
@cmwylie19 cmwylie19 moved this from 🆕 New to 🏗 In progress in Pepr Project Board Dec 4, 2024
@cmwylie19 cmwylie19 self-assigned this Dec 4, 2024
@cmwylie19 cmwylie19 mentioned this issue Dec 4, 2024
Merged
5 tasks
@cmwylie19 cmwylie19 moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
@cmwylie19
chore: return types on schedule (#1505)
b75ac42 
## Description

Adds return types to schedule to unify typing

## Related Issue

Fixes #1454 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
tech-debt
Projects
Pepr Project Board
Archived in project
Milestone
v0.42.0
Development

Successfully merging a pull request may close this issue.

chore: return types on schedule defenseunicorns/pepr
1 participant
@cmwylie19