Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking what's left for the migration to Qt #142

Closed
21 of 41 tasks
ErwanDL opened this issue Jun 26, 2022 · 3 comments
Closed
21 of 41 tasks

Tracking what's left for the migration to Qt #142

ErwanDL opened this issue Jun 26, 2022 · 3 comments

Comments

@ErwanDL
Copy link
Contributor

ErwanDL commented Jun 26, 2022

This is a tracking issue to try and list what components are yet to be migrated to Qt 5, and tick what has been done as progress is made. @perdrix52 don't hesitate to edit this or correct me if I'm wrong on this inventory.

Main components to be migrated to Qt

  • AskRegistering
  • BatchStacking
  • CheckAbove (in progress Iustin Amihaesei)
  • CometStacking
  • ControlPos (updated to support use of HWNDs and well as CWnd*)
  • DropFilesDlg
  • ExplorerBar
  • ImageSinks (obsolescent - replaced by DSS:EditStars and DSS::SelectRect) still used by ProcessingDlg
  • IntermediateFiles
  • LuminanceTab
  • OutputTab
  • PostCalibration
  • RawDDPSettings
  • RecommendedSettings
  • RegisterSettings
  • ResultParameters
  • SaveEditChanges
  • SettingsDlg
  • StackingDlg (Believed now completed)
  • StackingParameters
  • StackRecap
  • StackSettings
  • RGBTab
  • SaturationTab
  • PictureListCtrl (marked complete but obsolete - replaced by DSS:FrameList and QTableView in StackingDlg
  • ProcessingDlg
  • ProcessSettingsSheet (used by ProcessingDlg)
  • ProgressDlg (in progress - Simon Smith)
  • StarMaskDlg
  • SaveEditChanges
  • SavePicture
  • DSSLive/ImageView
  • DSSLive/GraphView
  • DSSLive/ImageList
  • DSSLive/StackedSink
  • DSSLive/LogTab
  • DSSLive/MainBoard
  • DSSLive/Settings
  • DSSLive/RestartMonitoring
  • DSSLive/EmailSettings
  • DSSLive/DeepSkyStackerLiveDlg

Inventory of Tools/ directory

The legacy GUI widgets live in the Tools/ directory. Some windows/dialogs listed above depend on these widgets, so we won't be able to migrate them without migrating the underlying widgets to Qt first (or replacing them by their direct Qt equivalent if any). The widgets/files in bold are the ones that seem to be unused. @perdrix52 can we safely delete those to clear up a bit this folder?

  • CButtonST: still used in several components: LuminanceTab, RGBTab, SaturationTab, StackingDlg, DSSLive/ImageView
  • CButtonToolbar/CButtonToolbarSink: still used by WndImage
  • CChildPropertyPage: still used in LuminanceTab, RGBTab, SaturationTab
  • CControlPos: still used in ProcessingDlg, DSSLive/GraphView, DSSLive/ImageList, DSSLive/ImageView, DSSLive/LogTab, DSSLive/MainBoard, DSSLive/Settings
  • EASYSIZE and related macros: still used in BatchStacking
  • CFolderDlg: still used in DSSLive/MainBoard and DSSLive/Settings
  • CGradient/CGradientCtrl/CGradientCtrlImpl: still used in ProcessingDlg, RGBTab, DSSLive/ImageView
  • CLabel: still used in LuminanceTab, ProcessingDlg, SaturationTab, DSSLive/ImageView, DSSLive/MainBoard, DSSLive/Settings
  • CListCtrlEx: still used in PictureListCtrl, DSSLive/ImageList
  • CSplitterControl: still used in StackingDlg Now Removed
  • CToolTipButton: still used in SavePicture
  • CWndImage/CWndImageSink: still used in ImageSinks, ProcessingDlg, StackingDlg, DSSLive/ImageView, DSSLive/StackedSink
@mtoeltsch
Copy link
Contributor

CSmartPtr/CRefCount: I already replaced them by shared_ptr and/or unique_ptr on a branch locally on my computer. If I find time I could open a new branch and cherry-pick the changes.

@perdrix52 perdrix52 pinned this issue Sep 13, 2022
@perdrix52
Copy link
Member

Made updates

@SimonCSmith
Copy link
Collaborator

New Qt based Progress Dialog completed for main DSS application and DSS CL. DSS Live version pending DSSL updated for Qt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants