Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize python code #1195

Merged
merged 4 commits into from
Jun 27, 2024
Merged

modernize python code #1195

merged 4 commits into from
Jun 27, 2024

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Jun 27, 2024

up to 3.8

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.27%. Comparing base (f7e131e) to head (da14f94).
Report is 10 commits behind head on main.

Current head da14f94 differs from pull request most recent head 6e29212

Please upload reports for the commit 6e29212 to get more accurate results.

Files Patch % Lines
dedupe/api.py 33.33% 2 Missing ⚠️
dedupe/core.py 77.77% 2 Missing ⚠️
dedupe/labeler.py 66.66% 1 Missing ⚠️
dedupe/predicates.py 92.85% 1 Missing ⚠️
dedupe/variables/base.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   73.57%   74.27%   +0.70%     
==========================================
  Files          29       29              
  Lines        2293     2216      -77     
==========================================
- Hits         1687     1646      -41     
+ Misses        606      570      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgregg fgregg merged commit 7d2c79b into main Jun 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant