Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize returns INVALID #295

Closed
rolfhaenni opened this issue Nov 9, 2023 · 2 comments
Closed

Serialize returns INVALID #295

rolfhaenni opened this issue Nov 9, 2023 · 2 comments

Comments

@rolfhaenni
Copy link

The serialize() algorithm in Section 4.2.4.1 does not include the case where an element of the input array is a string.
However, exactly this happens in Lines 4 of coreSign(), where the string comm passed as input value to serialize(). Therefore, currently serialize() would return the value INVALID. Besides, the commitment is missing in Line 2 of CoreVerify().

@BasileiosKal
Copy link
Contributor

This is absolutely correct! Resolved by PR 297. The commitment value is removed since it did not seem to serve much its original purpose, which was to support Blind BBS Signatures, now its own document.

Thank you for raising the issue! Will mark it as resolved and close it if there are no objections.

@BasileiosKal
Copy link
Contributor

Discussed on WG call at the 18th of Dec. Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants