-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amendment for run_query macro #656
Open
xemuliam
wants to merge
5
commits into
dbt-labs:main
Choose a base branch
from
xemuliam:run-query-amendment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xemuliam
had a problem deploying
to
dbt-redshift
January 26, 2025 09:01 — with
GitHub Actions
Failure
xemuliam
had a problem deploying
to
dbt-redshift
January 26, 2025 09:01 — with
GitHub Actions
Failure
xemuliam
temporarily deployed
to
dbt-snowflake
January 26, 2025 09:01 — with
GitHub Actions
Inactive
xemuliam
temporarily deployed
to
dbt-snowflake
January 26, 2025 09:01 — with
GitHub Actions
Inactive
xemuliam
temporarily deployed
to
dbt-snowflake
January 26, 2025 09:01 — with
GitHub Actions
Inactive
xemuliam
temporarily deployed
to
dbt-snowflake
January 26, 2025 09:01 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Different DBT backends treat SQL query differently. For example, BigQuery can run several SQL statements as a single SQL-script.
Snowflake and Databricks can't behave in that way and require to run single SQL statement at a time.
Thus what we can do if we need to run several SQL statements?
Here you can see several options available atb the moment:
Can we treat that as convenient? Probably not
Solution
Let's amend existing
run_query
macro to let it be executed in either single statement/script or bulk mode. Default execution mode isscript
. If someone wants to use it inbulk
mode then the only thing needs to be added is a macro's parameterbulk=True
.Proposed change is not breaking. Not even single existing macro invocation will be jeopardized.
Checklist