From 0da2d30f25bc00ba09d65d6f948325fa6fa277a2 Mon Sep 17 00:00:00 2001 From: Matthias Lindinger Date: Wed, 13 Mar 2024 10:49:08 +0100 Subject: [PATCH] Rename `locale` to `pLocale` in the client --- CHANGELOG.md | 1 + .../cudami/client/identifiable/CudamiIdentifiablesClient.java | 2 +- .../identifiable/BaseCudamiIdentifiablesClientTest.java | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 26d2fcdb4..b3768410f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -71,6 +71,7 @@ This version changes both the `groupId` and `artifactId` of the contained maven - Several missing `equals` & `hashCode` methods are added to model classes - Order of a website's root webpages is retained +- Renamed parameter `locale` to `pLocale` in the client ## [8.0.3](https://github.com/dbmdz/cudami/releases/tag/8.0.3) – 2024-01-19 diff --git a/metasvc-client/src/main/java/de/digitalcollections/cudami/client/identifiable/CudamiIdentifiablesClient.java b/metasvc-client/src/main/java/de/digitalcollections/cudami/client/identifiable/CudamiIdentifiablesClient.java index d9ba70757..88e8d9feb 100644 --- a/metasvc-client/src/main/java/de/digitalcollections/cudami/client/identifiable/CudamiIdentifiablesClient.java +++ b/metasvc-client/src/main/java/de/digitalcollections/cudami/client/identifiable/CudamiIdentifiablesClient.java @@ -121,7 +121,7 @@ public I getByUuidAndLocale(UUID uuid, Locale locale) throws TechnicalException public I getByUuidAndLocale(UUID uuid, String locale) throws TechnicalException { try { - return doGetRequestForObject(String.format(baseEndpoint + "/%s?locale=%s", uuid, locale)); + return doGetRequestForObject(String.format(baseEndpoint + "/%s?pLocale=%s", uuid, locale)); } catch (ResourceNotFoundException e) { return null; } diff --git a/metasvc-client/src/test/java/de/digitalcollections/cudami/client/identifiable/BaseCudamiIdentifiablesClientTest.java b/metasvc-client/src/test/java/de/digitalcollections/cudami/client/identifiable/BaseCudamiIdentifiablesClientTest.java index 15e56ac59..d0a114c48 100644 --- a/metasvc-client/src/test/java/de/digitalcollections/cudami/client/identifiable/BaseCudamiIdentifiablesClientTest.java +++ b/metasvc-client/src/test/java/de/digitalcollections/cudami/client/identifiable/BaseCudamiIdentifiablesClientTest.java @@ -65,7 +65,7 @@ public void testGetByUuidAndLocale() throws Exception { Locale locale = Locale.GERMAN; client.getByUuidAndLocale(uuid, locale); - verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?locale=" + locale); + verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?pLocale=" + locale); } @Test @@ -75,7 +75,7 @@ public void testGetByUuidAndLocaleAsString() throws Exception { String locale = Locale.GERMAN.toString(); client.getByUuidAndLocale(uuid, locale); - verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?locale=" + locale); + verifyHttpRequestByMethodAndRelativeURL("get", "/" + uuid + "?pLocale=" + locale); } @Test