New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image srcSets not escaped, breaks on paths with spaces in them #85

Open

grrowl opened this issue May 9, 2019 · 1 comment

grrowl commented May 9, 2019 •

edited

Loading

Because srcSet's paths are not escaped, it will produce this invalid output;

<img 
  src="/_next/static/images/Review List-711-834bd42895bd86b4f618f1dedcf9df31.png" 
  srcSet="/_next/static/images/Review List-711-834bd42895bd86b4f618f1dedcf9df31.png 711w"
/>

resulting in this error in the conosle (in Chrome):

Dropped srcset candidate "/_next/static/images/Review"
Failed parsing 'srcset' attribute value since it has an unknown descriptor.

The text was updated successfully, but these errors were encountered:

TrevinAvery commented Jul 9, 2021

I just discovered this is still an issue. For clarity, the correct output should be

<img 
  src="/_next/static/images/Review%20List-711-834bd42895bd86b4f618f1dedcf9df31.png" 
  srcSet="/_next/static/images/Review%20List-711-834bd42895bd86b4f618f1dedcf9df31.png 711w"
/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment