From 83c77b12bdba61505b6add39b2cdd57947b7a574 Mon Sep 17 00:00:00 2001 From: Cor Zuurmond Date: Fri, 10 Jan 2025 13:24:29 +0100 Subject: [PATCH 1/4] Fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 53ffe5df33..ee983a0b6c 100644 --- a/README.md +++ b/README.md @@ -2115,7 +2115,7 @@ are eligible to be run as a collection. User can run the below commands as colle - `migrate-tables` - `migrate-acls` - `migrate-dbsql-dashboards` -- `validate-group-membership` +- `validate-groups-membership` Ex: `databricks labs ucx ensure-assessment-run --run-as-collection=True` From 6072342072801fc0c9e537fe022885531d177d4b Mon Sep 17 00:00:00 2001 From: Cor Zuurmond Date: Fri, 10 Jan 2025 13:27:59 +0100 Subject: [PATCH 2/4] Fix order of running `validate-groups-membership` command --- README.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index ee983a0b6c..0d44f7bc4b 100644 --- a/README.md +++ b/README.md @@ -781,7 +781,8 @@ A Databricks admin [assigns account groups to workspaces](https://docs.databrick using [identity federation](https://docs.databricks.com/en/admin/users-groups/index.html#enable-identity-federation) to manage groups from a single place: your Databricks account. We expect UCX users to create account groups centrally while most other Databricks resources that UCX touches are scoped to a single workspace. -If you do not have account groups matching the workspace in which UCX is installed, please +For extra confidence, run [`validate-groups-membership` command](#validate-groups-membership-command) before running the +group migration. If you do not have account groups matching groups in the workspace in which UCX is installed, you can run [`create-account-groups` command](#create-account-groups-command) before running the group migration workflow. The group migration workflow is designed to migrate workspace-local groups to account-level groups. It verifies if @@ -822,13 +823,11 @@ executed after a successful run of the assessment workflow. The group migration destination groups. After successfully running the group migration workflow: -1. Use [`validate-groups-membership` command](#validate-groups-membership-command) for extra confidence the newly created - account level groups are considered to be valid. -2. Run the [`remove-workspace-local-backup-grups`](#validate-groups-membership-command) to remove workspace-level backup +1. Run the [`remove-workspace-local-backup-grups`](#validate-groups-membership-command) to remove workspace-level backup groups, along with their permissions. This should only be executed after confirming that the workspace-local migration worked successfully for all the groups involved. This step is necessary to clean up the workspace and remove any unnecessary groups and permissions. -3. Proceed to the [table migration process](#Table-Migration). +2. Proceed to the [table migration process](#Table-Migration). For additional information see: - The [detailed design](docs/local-group-migration.md) of thie group migration workflow. From e514d0b3a9dcd83a9a4cbcbdaa5daf7bd7fd7f7a Mon Sep 17 00:00:00 2001 From: Cor Zuurmond Date: Fri, 10 Jan 2025 13:28:45 +0100 Subject: [PATCH 3/4] Fix references to group migration workflow and design document --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0d44f7bc4b..a2d8b4329e 100644 --- a/README.md +++ b/README.md @@ -1983,8 +1983,8 @@ Workspace Group Name Members Count Account Group Name Members Count Differen This command validates the groups to see if the groups at the account level and workspace level have different membership. This command is useful for administrators who want to ensure that the groups have the correct membership. It can also be -used to debug issues related to group membership. See [group migration](docs/local-group-migration.md) and -[group migration](#group-migration-workflow) for more details. +used to debug issues related to group membership. See [group migration workflow](#group-migration-workflow) and +[group migration design document](docs/local-group-migration.md) for more details. Valid group membership is important to ensure users has correct access after legacy table ACL is migrated in [table migration process](#Table-Migration) From 63cf865f1a0d4c51d4a9e304916f6ff069ee5ba2 Mon Sep 17 00:00:00 2001 From: Cor Zuurmond Date: Fri, 10 Jan 2025 13:29:14 +0100 Subject: [PATCH 4/4] Update TOC --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index a2d8b4329e..1722c5847b 100644 --- a/README.md +++ b/README.md @@ -82,6 +82,7 @@ See [contributing instructions](CONTRIBUTING.md) to help improve this project. * [`legacy-context-in-shared-clusters`](#legacy-context-in-shared-clusters) * [`not-supported`](#not-supported) * [`notebook-run-cannot-compute-value`](#notebook-run-cannot-compute-value) + * [`python-parse-error`](#python-parse-error) * [`python-udf-in-shared-clusters`](#python-udf-in-shared-clusters) * [`rdd-in-shared-clusters`](#rdd-in-shared-clusters) * [`spark-logging-in-shared-clusters`](#spark-logging-in-shared-clusters)