Feature: Group storage configuration types in StorageTypeConfig trait
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schreter
commented
Nov 20, 2023
There was a problem hiding this comment.
+reviewer:@drmingdrmer
This is a starting point. Maybe it can be merged, maybe it'll require further work (docs).
I added compat-08 flag to all crates except memstore, where it's now using the new API version.
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @drmingdrmer)
|
@schreter |
This addresses databendlabs#938 partially (just the outer API level).
schreter
force-pushed
the
store_trait
branch
from
41ef31a to
95612d4
Compare
schreter
commented
Nov 20, 2023
There was a problem hiding this comment.
Right, that would be even better.
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on @drmingdrmer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #938 partially (just the outer API level).
This change is