You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
yarn build should exit with an error if the build does not succeed
Current Behavior
yarn build succeeds even if the build failed
Possible Solution
Steps to Reproduce (for bugs)
On arm64 arch:
Modify packages/dapi-grpc/scripts/build.sh and set a broken docker PROTOC_IMAGE, e.g. PROTOC_IMAGE="rvolosatovs/protoc:v4.0.0-rc2"
corepack enable
yarn install
yarn build
Output:
│ Status: Downloaded newer image for rvolosatovs/protoc:v4.0.0-rc2
│ protoc-gen-grpc-java: program not found or is not executable
│ Please specify a program using absolute path or make sure the program is available in your PATH system variable
│ --grpc-java_out: protoc-gen-grpc-java: Plugin failed with status code 1.
...
success ✨ Done in 64.027s
> echo $?
0 <------- return code should be 1
Context
As arm support is added upstream I would like to stop using the custom grpc images strophy/grpc-web-common and strophy/protoc. We need the build to fail if an intermediate step failed, so we know when something is not working in one of the dependency images.
Your Environment
Version used: 0.23-dev
Environment name and version (e.g. Chrome 39, node.js 5.4): Node 16.15.0, Docker 20.10.16
Operating System and version (desktop, server, or mobile): Ubuntu 22.04 AWS arm64
Link to your project:
The text was updated successfully, but these errors were encountered:
Expected Behavior
yarn build
should exit with an error if the build does not succeedCurrent Behavior
yarn build
succeeds even if the build failedPossible Solution
Steps to Reproduce (for bugs)
On
arm64
arch:packages/dapi-grpc/scripts/build.sh
and set a broken docker PROTOC_IMAGE, e.g.PROTOC_IMAGE="rvolosatovs/protoc:v4.0.0-rc2"
Output:
Context
As arm support is added upstream I would like to stop using the custom grpc images
strophy/grpc-web-common
andstrophy/protoc
. We need the build to fail if an intermediate step failed, so we know when something is not working in one of the dependency images.Your Environment
The text was updated successfully, but these errors were encountered: