Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn build reports success even if build failed #393

Open
strophy opened this issue May 16, 2022 · 0 comments
Open

yarn build reports success even if build failed #393

strophy opened this issue May 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@strophy
Copy link
Collaborator

strophy commented May 16, 2022

Expected Behavior

yarn build should exit with an error if the build does not succeed

Current Behavior

yarn build succeeds even if the build failed

Possible Solution

Steps to Reproduce (for bugs)

On arm64 arch:

  1. Modify packages/dapi-grpc/scripts/build.sh and set a broken docker PROTOC_IMAGE, e.g. PROTOC_IMAGE="rvolosatovs/protoc:v4.0.0-rc2"
  2. corepack enable
  3. yarn install
  4. yarn build

Output:

      │ Status: Downloaded newer image for rvolosatovs/protoc:v4.0.0-rc2
      │ protoc-gen-grpc-java: program not found or is not executable
      │ Please specify a program using absolute path or make sure the program is available in your PATH system variable
      │ --grpc-java_out: protoc-gen-grpc-java: Plugin failed with status code 1.
...
success ✨ Done in 64.027s
> echo $?
0 <------- return code should be 1

Context

As arm support is added upstream I would like to stop using the custom grpc images strophy/grpc-web-common and strophy/protoc. We need the build to fail if an intermediate step failed, so we know when something is not working in one of the dependency images.

Your Environment

  • Version used: 0.23-dev
  • Environment name and version (e.g. Chrome 39, node.js 5.4): Node 16.15.0, Docker 20.10.16
  • Operating System and version (desktop, server, or mobile): Ubuntu 22.04 AWS arm64
  • Link to your project:
@strophy strophy added the bug Something isn't working label May 16, 2022
@shumkov shumkov moved this to Backlog in Platform team Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant