Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable override auto-complete doesn't differenciate between getter and setter #59929

Open
FMorschel opened this issue Jan 17, 2025 · 1 comment
Labels
analyzer-completion Issues with the analysis server's code completion feature analyzer-completion-correctness analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@FMorschel
Copy link
Contributor

If you have code like:

class A {
  A(this.value);
  int value;
}

class B extends A {
  B(super.value);
  @override^
}

And you ask for code completion at ^ and continue writing value this is the output:

Image


If you ask for something that is not in scope, it'll show on the right side what is the library that will be imported:

Image


Could we use that place for differentiating between getter and setter?

CC @DanTup

@FMorschel FMorschel added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jan 17, 2025
@scheglov scheglov added analyzer-completion Issues with the analysis server's code completion feature analyzer-server analyzer-completion-correctness P2 A bug or feature request we're likely to work on labels Jan 17, 2025
@DanTup
Copy link
Collaborator

DanTup commented Jan 20, 2025

I added this to the end of the detail field (since the detail on the right is always the URI right now). It looks like this:

Image

Image

https://dart-review.googlesource.com/c/sdk/+/405007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-completion Issues with the analysis server's code completion feature analyzer-completion-correctness analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

3 participants