Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflectClass on record type crashes VM #59863

Closed
lrhn opened this issue Jan 8, 2025 · 0 comments
Closed

reflectClass on record type crashes VM #59863

lrhn opened this issue Jan 8, 2025 · 0 comments
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors type-enhancement A request for a change that isn't a bug

Comments

@lrhn
Copy link
Member

lrhn commented Jan 8, 2025

Example:

import "dart:mirrors";
typedef Rec = (int,);
void main() {
  reflectClass(Rec);
}

I know dart:mirrors are not really supported, but crashing with a segmentation fault seems a little harsher than necessary. Throwing UnuspportedError for unrecognized types seems safer than a native assertion failure.
@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors type-enhancement A request for a change that isn't a bug labels Jan 8, 2025
@alexmarkov alexmarkov self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrhn @alexmarkov